Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out bottom bar component padding issues #49

Closed
snide opened this issue Oct 25, 2017 · 0 comments
Closed

Figure out bottom bar component padding issues #49

snide opened this issue Oct 25, 2017 · 0 comments
Assignees

Comments

@snide
Copy link
Contributor

snide commented Oct 25, 2017

Bottom bar uses fixed position on the screen. This means it will often overlap content at the bottom of the normally rendered page. We should find some way to apply a bottom padding (bottom bar height + $kuiSizeL) to the bottom of the page to account for it.

Possibilities I can think of:

  • Do a domNode check and just apply a class to the body. Only one body in a page, so should be ok.
  • Make some sort of prop on a body component to account for this kind of thing. Lower level item would need to talk up the chain.
snide added a commit to snide/eui that referenced this issue Mar 9, 2018
@snide snide closed this as completed in #487 Mar 9, 2018
snide added a commit that referenced this issue Mar 9, 2018
* fix pagination arrows
* use portal on bottom bar, fixes #49
* fix dark theme disable button contrast, fixes #217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants