Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Add an option to configure wording and display of "Hit Enter to add ... as a custom option" #3702

Closed
yuliacech opened this issue Jul 7, 2020 · 3 comments · Fixed by #3811
Assignees

Comments

@yuliacech
Copy link
Contributor

Hello team,
while working on #70627 in Kibana, I noticed that there is no option to configure the wording and overall display for when the input value doesn't match any existing options.

I think for the following use case, such an option would be very useful:

  • The user can type in any value as a "wait for snapshot" policy name when configuring "Delete phase" on Index Lifecycle Policies page.
  • The UI should be helpful in that it displays existing snapshot policies as options list.
  • The user should not be blocked from typing in any value.

Currently, the UI displays a callout beyond the combobox but it seems like the callout and the "Hit ENTER ..." wording compete to say the same thing. The general "Hit ENTER ..." wording doesn't provide all the useful information though.
wait_for_snapshot_policy_combobox
custom_policy_callout

@elizabetdev elizabetdev self-assigned this Jul 13, 2020
@elizabetdev
Copy link
Contributor

@cchaos,

Before I start implementing do you think one of the following options would work?

The idea is to separate the enter key from the custom text.

combo-box-custom-option-text@2x

@cchaos
Copy link
Contributor

cchaos commented Jul 15, 2020

That is actually reminding me of the proposed Global Search dropdown where focused items get a badge on the right with the return symbol . So it might be nice to add a similar indicator to all focused items, with something slightly different for this custom option.
Screen Shot 2020-07-15 at 09 44 29 AM

The ComboBox's items most likely won't wrap multiple lines so I'd stick with the shorter description.

In terms of what is customizable, will the consumer have to pass the entire Save <strong>[entered text]</strong> as a new snapshot policy or will only part of that sentence be customized?

@elizabetdev
Copy link
Contributor

@cchaos I was thinking to allow to pass the entire text with the entered string just because it will be difficult to predict all the possible texts.

I'll update the mockups with a similar badge indicator to all focused items and something slightly different for the custom option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants