Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiColorPicker] Prepend should shift popover to align to input #2824

Closed
cchaos opened this issue Feb 4, 2020 · 9 comments
Closed

[EuiColorPicker] Prepend should shift popover to align to input #2824

cchaos opened this issue Feb 4, 2020 · 9 comments

Comments

@cchaos
Copy link
Contributor

cchaos commented Feb 4, 2020

The left side of the popover is aligned with the prepend versus the actual input. It should align to the input.

Screen Shot 2020-02-04 at 11 33 55 AM

Originally posted by @cchaos in #2819 (comment)

@anishagg17
Copy link
Contributor

@cchaos I want to work over this

@chandlerprall
Copy link
Contributor

@cchaos should the prepend/append areas still trigger the popover, or should it only be from interacting with the input element?

@anishagg17 it's available for you to take on, I'll add some thoughts on how to approach this but I'll wait for the above question to be answered first

@cchaos
Copy link
Contributor Author

cchaos commented Feb 24, 2020

No, the prepend/appends should not trigger the popover as they could be buttons that do something else. I believe if the a simple string is passed as the elements, then it properly hooks up as the <label> of the input so by default it would act as a trigger and we shouldn't force it otherwise.

@chandlerprall
Copy link
Contributor

chandlerprall commented Mar 3, 2020

Getting back to adding thoughts here:

Either:

  • the color picker's usage of EuiPopover needs to be refactored to not wrap the prepend/append buttons
  • EuiPopover needs a complimentary structure that allows for redirecting the ref it applies to the button. Like some weird:
<EuiPopoverRef>
  {ref => <EuiPopover button={somethingWithThatRef}>...</EuiPopover>}
</EuiPopoverRef>

The second one feels really awkward, so I'd lean toward trying out first option.

@cchaos cchaos changed the title EuiColorPicker with prepend should shift popover to align to input [EuiColorPicker] Prepend should shift popover to align to input Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

@github-actions
Copy link

❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants