-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiColorPicker] Prepend should shift popover to align to input #2824
Comments
@cchaos I want to work over this |
@cchaos should the prepend/append areas still trigger the popover, or should it only be from interacting with the input element? @anishagg17 it's available for you to take on, I'll add some thoughts on how to approach this but I'll wait for the above question to be answered first |
No, the prepend/appends should not trigger the popover as they could be buttons that do something else. I believe if the a simple string is passed as the elements, then it properly hooks up as the |
Getting back to adding thoughts here: Either:
<EuiPopoverRef>
{ref => <EuiPopover button={somethingWithThatRef}>...</EuiPopover>}
</EuiPopoverRef> The second one feels really awkward, so I'd lean toward trying out first option. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context. |
The left side of the popover is aligned with the prepend versus the actual input. It should align to the input.
Originally posted by @cchaos in #2819 (comment)
The text was updated successfully, but these errors were encountered: