Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiCodeBlock always expands to overflowHeight #2435

Closed
jen-huang opened this issue Oct 15, 2019 · 0 comments · Fixed by #2487
Closed

EuiCodeBlock always expands to overflowHeight #2435

jen-huang opened this issue Oct 15, 2019 · 0 comments · Fixed by #2487
Assignees
@andreadelrio
Labels
bug good first issue

Comments

@jen-huang
Copy link
Contributor

EuiCodeBlock always expands to the given overflowHeight, even when content does not reach that length. In this screenshot both code blocks are set to overflowHeight={300}:

image

overflowHeight should only kick in when content actually overflows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreadelrio andreadelrio

Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix overflowHeight in EuiCodeBlock andreadelrio/eui
3 participants
@snide @jen-huang @andreadelrio