Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Drawer flyoutMenu broken on production build (documentation's example/CRA) #2175

Closed
kkensy opened this issue Jul 28, 2019 · 3 comments · Fixed by #2178
Closed

Nav Drawer flyoutMenu broken on production build (documentation's example/CRA) #2175

kkensy opened this issue Jul 28, 2019 · 3 comments · Fixed by #2178
Assignees

Comments

@kkensy
Copy link

kkensy commented Jul 28, 2019

Hi. The flyoutMenu of the Nav Drawer does not work anymore in the documentation's example (v13.0.0). Nothing happens when I click or hover over the menu items.

I'm using EUI with a Create React App standalone project. After integrating the Nav Drawer in my project, I have noticed that the flyoutMenu do not work in the production build (yarn build). However it does work in the dev environment (yarn start). I have already observed this behavior in the previous versions of EUI (<13.0.0). You can find here an prepared example, based on the Demo JS code from the documentation.

What should I do in this case? I hope it does not require to eject my CRA project.

@chandlerprall chandlerprall self-assigned this Jul 29, 2019
@thompsongl
Copy link
Contributor

@chandlerprall I narrowed down the problem in our documentation to #2053, so it goes back to the 12.0.0 timeframe

@thompsongl
Copy link
Contributor

thompsongl commented Jul 29, 2019

Likely the logic here: https://github.com/elastic/eui/blob/master/src/components/nav_drawer/nav_drawer.js#L219

if (child.type.name === 'EuiNavDrawerGroup')

Minification almost certainly mangles the component name

@chandlerprall
Copy link
Contributor

Thanks @kkensy for catching and reporting! The fix for this has been released in @elastic/eui@13.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants