Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiColorPicker focus & popover behavior #1988

Closed
thompsongl opened this issue May 31, 2019 · 1 comment · Fixed by #2038
Closed

EuiColorPicker focus & popover behavior #1988

thompsongl opened this issue May 31, 2019 · 1 comment · Fixed by #2038

Comments

@thompsongl
Copy link
Contributor

As discussed in #1914 (comment), we may want to alter the open-on-focus behavior of the popover in EuiColorPicker.

The gist is that a user navigating via keyboard is forced to close the popover when attempting to tab through a form. We'll likely want more explicit open & close actions, similar to EuiSelect

@thompsongl
Copy link
Contributor Author

Prior discussion:

I don't think this particular use-case needs the dropdown arrow. Someone using the keyboard for navigation should get a VO read out telling them to hit "space" to "enter this input" or whatever. The arrow would be misleading in this case because we use that to indicate there are predefined choices but the color picker isn't necessarily that.

I do think we'd need a visual cue to compliment the VO cue for keyboard navigators not using VO. There's a discoverability problem otherwise; it just looks like a text box.

If you're turning off the auto open, then you'll need something that opens it up. I'm torn between thinking that the caret should be a button or whether it should be purely visual and you hit something like "downarrow" for trigger the popover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant