New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building (and dev) on Windows is broken #1753

Closed

chandlerprall opened this issue Mar 21, 2019 · 0 comments · Fixed by #1891

Contributor

chandlerprall commented Mar 21, 2019 •

edited

Loading

In order to build (or dev) on Windows, currently these two manual changes must be applied

.babelrc - line 14, change "@babel/typescript" to

[
  "@babel/typescript",
  {
    "isTSX": true,
    "allExtensions": true
  }
}

node_modules/scss-parser/dist/token-stream.js needs to change line 57 from '\t\n ' to '\t\n\r '

This should be corrected so no manual steps must be taken.

In addition, pre-commit hook fails on Windows, see #1757

The text was updated successfully, but these errors were encountered:

chandlerprall added the assign:engineer label

thompsongl mentioned this issue

Build: babel/proptypes-from-ts-props fails #1757

Closed

chandlerprall mentioned this issue

allow builds to succeed on Windows #1891

Merged

2 tasks

chandlerprall closed this as completed in #1891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment