Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eui.d.ts declares non-eui modules #1388

Closed
chandlerprall opened this issue Dec 19, 2018 · 1 comment · Fixed by #1395
Closed

eui.d.ts declares non-eui modules #1388

chandlerprall opened this issue Dec 19, 2018 · 1 comment · Fixed by #1395
Labels
typescript

Comments

@chandlerprall
Copy link
Contributor

chandlerprall commented Dec 19, 2018 •
edited
Loading

The definitions in EUI for *.png and *.svg are making their way into eui.d.ts - we should only export @elastic/eui/* modules defs.
@pugnascotia
Copy link
Contributor

I'll take a crack at this since it's preventing Cloud from upgrading.

pugnascotia added a commit to pugnascotia/eui that referenced this issue Dec 21, 2018
@pugnascotia
Exclude custom_typings from eui.d.ts
addd46a 
Closes elastic#1388.
@pugnascotia pugnascotia mentioned this issue Dec 21, 2018
Merged
10 tasks
pugnascotia added a commit that referenced this issue Dec 21, 2018
@pugnascotia
Exclude custom_typings from eui.d.ts (#1395)
c0cda96 
Closes #1388. The `src/custom_typings` directory contains some TS definitions that allows TS files to import images without complaint. However, these definitions were being included in `eui.d.ts`, which meant downstream projects couldn't include their own mechanisms for importing images. The fix is to exclude `custom_typings` from `eui.d.ts`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude custom_typings from eui.d.ts pugnascotia/eui
2 participants
@chandlerprall @pugnascotia