Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover in modal doesn't trigger click event #1051

Closed
cqliu1 opened this issue Jul 26, 2018 · 1 comment · Fixed by #1550
Closed

Popover in modal doesn't trigger click event #1051

cqliu1 opened this issue Jul 26, 2018 · 1 comment · Fixed by #1550
Assignees
Labels

Comments

@cqliu1
Copy link
Contributor

cqliu1 commented Jul 26, 2018

I'm using an EuiBasicTable with pagination in an EuiModal, and I'm not able to change the rows per page. The onChange handler passed to the EuiBasicTable isn't being triggered from the popover.

jul-26-2018 14-45-38

It works when the table isn't inside a modal.

jul-26-2018 14-56-46

@chandlerprall chandlerprall self-assigned this Jul 27, 2018
@chandlerprall
Copy link
Contributor

chandlerprall commented Jul 27, 2018

root cause: focus-trap-react stops click event propagation if 1. clickOutsideDeactivates prop is false and 2. the target element isn't in the focus trap's descendant DOM tree (which is true in this case because the popover is rendered via a portal)

looking into solutions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants