From c99dceccc75dba1eeae5d1bb1dec7cb87f1af4bb Mon Sep 17 00:00:00 2001 From: Elizabet Oliveira Date: Tue, 4 Feb 2020 19:23:59 +0000 Subject: [PATCH] Third-party logos optimization (#2812) * Optimizing third party logos * Adding changelog * Updating snapshots tests --- CHANGELOG.md | 1 + .../icon/__snapshots__/icon.test.tsx.snap | 306 ++++++++++++++++-- src/components/icon/assets/logo_ceph.js | 10 +- src/components/icon/assets/logo_ceph.svg | 4 +- src/components/icon/assets/logo_dropwizard.js | 53 ++- .../icon/assets/logo_dropwizard.svg | 22 +- src/components/icon/assets/logo_golang.js | 133 +++++++- src/components/icon/assets/logo_golang.svg | 38 ++- src/components/icon/assets/logo_haproxy.js | 73 ++++- src/components/icon/assets/logo_haproxy.svg | 198 +++++++++++- 10 files changed, 776 insertions(+), 62 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 43c4d6609fd..8da99eb68a6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ - Added `tableCaption` prop to `EuiBasicTable` and improved the default one ([#2782](https://github.com/elastic/eui/pull/2782)) - Converted `EuiDescribedFormGroup` to TypeScript ([#2810](https://github.com/elastic/eui/pull/2810)) - Changed SASS comments to non-compiled comments in invisibles files ([#2807](https://github.com/elastic/eui/pull/2807)) +- Optimized the third party logos Ceph, DropWizard, Golang, and Haproxy ([#2812](https://github.com/elastic/eui/pull/2812)) - Added `rowHeader` prop to `EuiBasicTable` to allow consumers to set the identifying cell in a row ([#2802](https://github.com/elastic/eui/pull/2802)) - Added prepend and append to `EuiColorPicker` ([#2819](https://github.com/elastic/eui/pull/2819)) - Improved `EuiDescribedFormGroup` accessibility by avoiding duplicated output in screen readers ([#2783](https://github.com/elastic/eui/pull/2783)) diff --git a/src/components/icon/__snapshots__/icon.test.tsx.snap b/src/components/icon/__snapshots__/icon.test.tsx.snap index 406c585478a..21ffeb4dcc8 100644 --- a/src/components/icon/__snapshots__/icon.test.tsx.snap +++ b/src/components/icon/__snapshots__/icon.test.tsx.snap @@ -3616,6 +3616,7 @@ exports[`EuiIcon props type logoCeph is rendered 1`] = ` `; @@ -3774,6 +3772,7 @@ exports[`EuiIcon props type logoDropwizard is rendered 1`] = ` `; @@ -4105,6 +4166,7 @@ exports[`EuiIcon props type logoGolang is rendered 1`] = ` `; @@ -4127,6 +4313,7 @@ exports[`EuiIcon props type logoHAproxy is rendered 1`] = ` `; diff --git a/src/components/icon/assets/logo_ceph.js b/src/components/icon/assets/logo_ceph.js index 0a4f22aff04..e830033c0d2 100644 --- a/src/components/icon/assets/logo_ceph.js +++ b/src/components/icon/assets/logo_ceph.js @@ -5,16 +5,14 @@ const EuiIconLogoCeph = ({ title, titleId, ...props }) => ( width={32} height={32} viewBox="0 0 32 32" + fill="none" xmlns="http://www.w3.org/2000/svg" aria-labelledby={titleId} {...props}> {title ? {title} : null} - ); diff --git a/src/components/icon/assets/logo_ceph.svg b/src/components/icon/assets/logo_ceph.svg index be9d721800a..2a5b4111d93 100644 --- a/src/components/icon/assets/logo_ceph.svg +++ b/src/components/icon/assets/logo_ceph.svg @@ -1,3 +1,3 @@ - - + + diff --git a/src/components/icon/assets/logo_dropwizard.js b/src/components/icon/assets/logo_dropwizard.js index 741e975e6c5..d488ebdb155 100644 --- a/src/components/icon/assets/logo_dropwizard.js +++ b/src/components/icon/assets/logo_dropwizard.js @@ -5,18 +5,57 @@ const EuiIconLogoDropwizard = ({ title, titleId, ...props }) => ( width={32} height={32} viewBox="0 0 32 32" + fill="none" xmlns="http://www.w3.org/2000/svg" aria-labelledby={titleId} {...props}> {title ? {title} : null} - + + + + + + + + + + + + + + + + + + ); diff --git a/src/components/icon/assets/logo_dropwizard.svg b/src/components/icon/assets/logo_dropwizard.svg index 6e7b3628726..c62372fa8e8 100644 --- a/src/components/icon/assets/logo_dropwizard.svg +++ b/src/components/icon/assets/logo_dropwizard.svg @@ -1,3 +1,21 @@ - - + + + + + + + + + + + + + + + + + + + + diff --git a/src/components/icon/assets/logo_golang.js b/src/components/icon/assets/logo_golang.js index f95b5fb54b3..5befa98a5e1 100644 --- a/src/components/icon/assets/logo_golang.js +++ b/src/components/icon/assets/logo_golang.js @@ -5,17 +5,136 @@ const EuiIconLogoGolang = ({ title, titleId, ...props }) => ( width={32} height={32} viewBox="0 0 32 32" + fill="none" xmlns="http://www.w3.org/2000/svg" aria-labelledby={titleId} {...props}> {title ? {title} : null} - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + ); diff --git a/src/components/icon/assets/logo_golang.svg b/src/components/icon/assets/logo_golang.svg index bd927c302c2..b01bcbc32d2 100644 --- a/src/components/icon/assets/logo_golang.svg +++ b/src/components/icon/assets/logo_golang.svg @@ -1,3 +1,37 @@ - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/components/icon/assets/logo_haproxy.js b/src/components/icon/assets/logo_haproxy.js index b0290bb62cb..2b3e5066de3 100644 --- a/src/components/icon/assets/logo_haproxy.js +++ b/src/components/icon/assets/logo_haproxy.js @@ -5,17 +5,76 @@ const EuiIconLogoHaproxy = ({ title, titleId, ...props }) => ( width={32} height={32} viewBox="0 0 32 32" + fill="none" xmlns="http://www.w3.org/2000/svg" aria-labelledby={titleId} {...props}> {title ? {title} : null} - + + + + + + + + + + + + + + + + + + + ); diff --git a/src/components/icon/assets/logo_haproxy.svg b/src/components/icon/assets/logo_haproxy.svg index 6a628be7646..f45c35d3434 100644 --- a/src/components/icon/assets/logo_haproxy.svg +++ b/src/components/icon/assets/logo_haproxy.svg @@ -1,3 +1,197 @@ - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +