From 38e2d9c5cb1b7d6cd2091a9921d6f317318c6557 Mon Sep 17 00:00:00 2001
From: cchaos
Date: Wed, 18 Apr 2018 15:22:45 -0400
Subject: [PATCH] Addressing PR comments
- Added to example
- fixed typo
---
src-docs/src/views/text/text.js | 24 ++++++++++++++++++++++++
src-docs/src/views/text/text_align.js | 2 +-
src-docs/src/views/text/text_small.js | 24 ++++++++++++++++++++++++
src/components/text/_text.scss | 10 ++++------
4 files changed, 53 insertions(+), 7 deletions(-)
diff --git a/src-docs/src/views/text/text.js b/src-docs/src/views/text/text.js
index 85d3303652d6..e4f104353482 100644
--- a/src-docs/src/views/text/text.js
+++ b/src-docs/src/views/text/text.js
@@ -2,6 +2,7 @@ import React from 'react';
import {
EuiText,
+ EuiHorizontalRule,
} from '../../../../src/components';
export default () => (
@@ -100,6 +101,29 @@ export default () => (
This is Heading Six
+
+
+
+
+ -
+ The Elder Scrolls: Morrowind
+
+ -
+ The opening music alone evokes such strong memories.
+
+ -
+ TIE Fighter
+
+ -
+ The sequel to XWING, join the dark side and fly for the Emporer.
+
+ -
+ Quake 2
+
+ -
+ The game that made me drop out of college.
+
+
);
diff --git a/src-docs/src/views/text/text_align.js b/src-docs/src/views/text/text_align.js
index b0e46802612f..cee46b1cb162 100644
--- a/src-docs/src/views/text/text_align.js
+++ b/src-docs/src/views/text/text_align.js
@@ -25,7 +25,7 @@ export default () => (
You can also pass alignment to EuiText directly with a prop
- And in conjuction with coloring.
+ And in conjunction with coloring.
);
diff --git a/src-docs/src/views/text/text_small.js b/src-docs/src/views/text/text_small.js
index cf0772ec445a..e1de7bb58e81 100644
--- a/src-docs/src/views/text/text_small.js
+++ b/src-docs/src/views/text/text_small.js
@@ -4,6 +4,7 @@ import {
EuiText,
EuiFlexGroup,
EuiFlexItem,
+ EuiHorizontalRule,
} from '../../../../src/components';
const exampleText = (
@@ -88,6 +89,29 @@ const exampleText = (
This is Heading Six
+
+
+
+
+ -
+ The Elder Scrolls: Morrowind
+
+ -
+ The opening music alone evokes such strong memories.
+
+ -
+ TIE Fighter
+
+ -
+ The sequel to XWING, join the dark side and fly for the Emporer.
+
+ -
+ Quake 2
+
+ -
+ The game that made me drop out of college.
+
+
);
diff --git a/src/components/text/_text.scss b/src/components/text/_text.scss
index 1a9e8f26a80c..12d62c9e21b9 100644
--- a/src/components/text/_text.scss
+++ b/src/components/text/_text.scss
@@ -55,7 +55,8 @@
line-height: convertToRem($baseLineHeightMultiplier * 4);
}
- h4 {
+ h4,
+ dt {
font-size: convertToRem($baseFontSize * nth($euiTextScale, 5)); // skip level 4 on purpose
}
@@ -110,10 +111,6 @@
list-style: decimal;
}
- dt {
- @include euiTitle("xs");
- }
-
blockquote {
position: relative;
text-align: center;
@@ -156,7 +153,8 @@
@include euiTitle("s");
}
- h4 {
+ h4,
+ dt {
@include euiTitle("xs");
}