From 15cf8f4d1d693e6dcc66f9ffab3d3be4a9c93b42 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 31 Jan 2020 15:24:16 -0500 Subject: [PATCH] Add Cheer glyph to EuiIcon (#2814) * Adding Cheer icon to EUI * Updating snapshots * Updating changelog. * Updating cheer icon to use outlines. * Updating snap. * Trying to pixel align icon * More confetti like than lines To try to remove the carrot likeness Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> --- CHANGELOG.md | 1 + src-docs/src/views/icon/icons.js | 1 + .../icon/__snapshots__/icon.test.tsx.snap | 17 +++++++++++++++++ src/components/icon/assets/cheer.js | 16 ++++++++++++++++ src/components/icon/assets/cheer.svg | 3 +++ src/components/icon/icon.tsx | 1 + 6 files changed, 39 insertions(+) create mode 100644 src/components/icon/assets/cheer.js create mode 100644 src/components/icon/assets/cheer.svg diff --git a/CHANGELOG.md b/CHANGELOG.md index f8844605c86..8fc8f3ebf15 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) +- Added `cheer` glyph to `EuiIcon` ([#2814](https://github.com/elastic/eui/pull/2814)) - Added `tableCaption` prop to `EuiBasicTable` and improved the default one ([#2782](https://github.com/elastic/eui/pull/2782)) - Changed SASS comments to non-compiled comments in invisibles files ([#2807](https://github.com/elastic/eui/pull/2807)) - Added `rowHeader` prop to `EuiBasicTable` to allow consumers to set the identifying cell in a row ([#2802](https://github.com/elastic/eui/pull/2802)) diff --git a/src-docs/src/views/icon/icons.js b/src-docs/src/views/icon/icons.js index 7ff0536f4ee..95ef52b5774 100644 --- a/src-docs/src/views/icon/icons.js +++ b/src-docs/src/views/icon/icons.js @@ -46,6 +46,7 @@ export const iconTypes = [ 'calendar', 'check', 'checkInCircleFilled', + 'cheer', 'clock', 'cloudDrizzle', 'cloudStormy', diff --git a/src/components/icon/__snapshots__/icon.test.tsx.snap b/src/components/icon/__snapshots__/icon.test.tsx.snap index 4f4d979b451..406c585478a 100644 --- a/src/components/icon/__snapshots__/icon.test.tsx.snap +++ b/src/components/icon/__snapshots__/icon.test.tsx.snap @@ -1011,6 +1011,23 @@ exports[`EuiIcon props type checkInCircleFilled is rendered 1`] = ` `; +exports[`EuiIcon props type cheer is rendered 1`] = ` + +`; + exports[`EuiIcon props type clock is rendered 1`] = `