Deprecate camelCase parameters used by SAML APIs #73984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-security (Team:Security) |
|
Ping @elastic/kibana-security. We're considering deprecating the current parameter you use, and switching it to |
|
Thanks for the ping. Sure, we'll track this PR and update Kibana code base for 7.14 as soon as updated ES snapshot reaches our CI. |
tvernum
reviewed
Jun 22, 2021
...ain/java/org/elasticsearch/xpack/security/rest/action/saml/RestSamlCompleteLogoutAction.java
Outdated
Show resolved
Hide resolved
…ecurity/rest/action/saml/RestSamlCompleteLogoutAction.java Co-authored-by: Tim Vernum <tim@adjective.org>
|
@elasticmachine update branch |
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Jun 23, 2021
Both SAML complete logout and SAML invalidate session APIs use a camelCase request parameter, queryString, while the convention is to use snake_case parameters. This PR deprecates queryString and replaces it with query_string. It is an error to if a request specifies both of them.
ywangd
added a commit
that referenced
this pull request
Jun 23, 2021
Both SAML complete logout and SAML invalidate session APIs use a camelCase request parameter, queryString, while the convention is to use snake_case parameters. This PR deprecates queryString and replaces it with query_string. It is an error to if a request specifies both of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both SAML complete logout and SAML invalidate session APIs use a camelCase request parameter,
queryString, while the convention is to use snake_case parameters. This PR deprecatesqueryStringand replaces it withquery_string. It is an error to if a request specifies both of them.Resolves: #73543