Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider which aggregations can support parallel execution #98669

Closed
martijnvg opened this issue Aug 21, 2023 · 2 comments
Closed

Reconsider which aggregations can support parallel execution #98669

martijnvg opened this issue Aug 21, 2023 · 2 comments
Assignees
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@martijnvg
Copy link
Member

martijnvg commented Aug 21, 2023

Currently parallel execution isn't enabled by default, but even when it is enabled then the following aggregations are set up the never execute in parallel: scripted_metric, parent , terms, multi_terms, and significant_terms.

There two main raisons for this is either precision of an aggregation will be different when execution in parallel mode or the aggregation couldn't be accessed from different threads. For latter, as part of #98204, the post collection happens on the same thread as the actual collection.

For the former reason, we properly need to get a better feeling what the impact in precision is in practise for the aggregations in question (for terms, multi_terms and significant_terms) and update the documentation about the additional loss in precision (next to the loss of precision when running these aggs on multiple shards).

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 21, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@wchaparro
Copy link
Member

Close as completed @iverase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

4 participants