Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILM tests have switches with impossible branches #88743

Closed
Tracked by #88739
pugnascotia opened this issue Jul 22, 2022 · 2 comments · Fixed by #88748
Closed
Tracked by #88739

ILM tests have switches with impossible branches #88743

pugnascotia opened this issue Jul 22, 2022 · 2 comments · Fixed by #88748
Assignees
@joegallo
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests

Comments

@pugnascotia
Copy link
Contributor

pugnascotia commented Jul 22, 2022 •
edited
Loading

The following ILM tests all contain switch statements with branches that will never execute. The tests use a between(x, y) switch expression, but there are case values that are outside the randomised range. We need to fix these before #88739 can be merged. By "fix", I mean either remove the spurious cases, or if we actually want them, then extend the randomized range.

  • ActionConfigStatsTests
  • AllocateActionTests
  • CopyExecutionStateStepTests
  • RolloverActionTests
  • WaitForRolloverReadyStepTests
@pugnascotia pugnascotia added >test Issues or PRs that are addressing/adding tests :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Jul 22, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jul 22, 2022
@joegallo joegallo self-assigned this Jul 22, 2022
@joegallo
Copy link
Contributor

I fixed some of these already on #83345, I'll get a clean PR up that just addresses only these and fixes them. Thanks, @pugnascotia!

@pugnascotia pugnascotia mentioned this issue Jul 22, 2022
Merged
4 tasks
@joegallo joegallo mentioned this issue Jul 22, 2022
Merged
@joegallo joegallo mentioned this issue Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joegallo joegallo

Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix erroneous switch/cases in ILM tests joegallo/elasticsearch
3 participants
@joegallo @pugnascotia @elasticsearchmachine