-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EQL: correct the request-wide timeout handling #74815
Comments
Pinging @elastic/es-ql (Team:QL) |
It looks like that the canonical way to handle request timeouts is to let the client close the connection when it is no longer interested in the response. The mechanism has been introduced in #43332. No other APIs that I'm aware of (expect _sql to some degree) support request timeouts in the sense of timing out the request on the server side. So instead of adding a request_timeout parameter we have to primarily ensure that all searches started by EQL are canceled when the connection is closed. This is currently not the case. |
That would seem like a legit solution. |
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Currently EQL user-request timeout isn't effectively covering the entire process leading to a response, but rather individual internal requests used to build the sequences; this can lead to issues with both user's response not being generated orderly, as well as the cluster doing work that's eventually discarded.
The issue is raised to correct this behaviour.
The text was updated successfully, but these errors were encountered: