Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQL: correct the request-wide timeout handling #74815

Open
bpintea opened this issue Jul 1, 2021 · 4 comments
Open

EQL: correct the request-wide timeout handling #74815

bpintea opened this issue Jul 1, 2021 · 4 comments
Labels
:Analytics/EQL EQL querying >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@bpintea
Copy link
Contributor

bpintea commented Jul 1, 2021

Currently EQL user-request timeout isn't effectively covering the entire process leading to a response, but rather individual internal requests used to build the sequences; this can lead to issues with both user's response not being generated orderly, as well as the cluster doing work that's eventually discarded.

The issue is raised to correct this behaviour.

@bpintea bpintea added >bug :Analytics/EQL EQL querying labels Jul 1, 2021
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Jul 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@Luegg
Copy link
Contributor

Luegg commented Oct 21, 2021

It looks like that the canonical way to handle request timeouts is to let the client close the connection when it is no longer interested in the response. The mechanism has been introduced in #43332.

No other APIs that I'm aware of (expect _sql to some degree) support request timeouts in the sense of timing out the request on the server side.

So instead of adding a request_timeout parameter we have to primarily ensure that all searches started by EQL are canceled when the connection is closed. This is currently not the case.

@bpintea
Copy link
Contributor Author

bpintea commented Oct 26, 2021

So instead of adding a request_timeout parameter we have to primarily ensure that all searches started by EQL are canceled when the connection is closed.

That would seem like a legit solution.

@wchaparro wchaparro removed the Team:QL (Deprecated) Meta label for query languages team label Jan 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

5 participants