-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant API key should mandate key name as create API key action #59484
Labels
>bug
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Team:Security
Meta label for security team
Comments
Pinging @elastic/es-security (:Security/Authentication) |
This was referenced Jul 14, 2020
ywangd
added a commit
that referenced
this issue
Jul 14, 2020
API keys can be created without names using grant API key action. This is considered as a bug (#59484). Since the feature has already been released, we need to accomodate existing keys that are created with null names. This PR relaxes the parser logic so that a null name is accepted.
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this issue
Jul 14, 2020
API keys can be created without names using grant API key action. This is considered as a bug (elastic#59484). Since the feature has already been released, we need to accomodate existing keys that are created with null names. This PR relaxes the parser logic so that a null name is accepted.
ywangd
added a commit
that referenced
this issue
Jul 14, 2020
API keys can be created without names using grant API key action. This is considered as a bug (#59484). Since the feature has already been released, we need to accomodate existing keys that are created with null names. This PR relaxes the parser logic so that a null name is accepted.
albertzaharovits
added a commit
that referenced
this issue
Jul 14, 2020
API keys can be created nameless using the grant endpoint (it is a bug, see #59484). This change ensures auditing doesn't throw when such an API Key is used for authentication.
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this issue
Jul 14, 2020
API keys can be created nameless using the grant endpoint (it is a bug, see elastic#59484). This change ensures auditing doesn't throw when such an API Key is used for authentication.
albertzaharovits
added a commit
that referenced
this issue
Jul 14, 2020
API keys can be created nameless using the grant endpoint (it is a bug, see #59484). This change ensures auditing doesn't throw when such an API Key is used for authn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Team:Security
Meta label for security team
The name of an API key is mandatory when creating an API key. It throws a
400
error if the name is missing. However, when using the grant API key action, it is possible to create a key without a name. This is because thename
field is nested underapi_key
field for the input of grant API key action, i.e.:Although the
name
field is still mandatory, the parentapi_key
field is optional. Thus allow keys be created without names.The text was updated successfully, but these errors were encountered: