Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be nice if zero_terms_query was supported by the new match_phrase syntax #29344

Closed
JFogh opened this issue Apr 3, 2018 · 5 comments
Closed
Assignees
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories v6.3.0 v7.0.0-beta1

Comments

@JFogh
Copy link

JFogh commented Apr 3, 2018

Describe the feature:
In the new NEST version 6.x.x the "type" option on "match" query is obsolete.
Thus you now use "match_phrase" instead of match with type "phrase".
When using the old "match" there was a "zero_terms_query" possibility supported.
This is not supported by the "match_phrase" query.
This makes it harder to rewrite queries using the old "match"-syntax to use the new "match_phrase",
thus it would be nice to have the "zero_terms_query" possibility, especially for backwards compability.

Elasticsearch version (bin/elasticsearch --version):

Plugins installed: []

JVM version (java -version):

OS version (uname -a if on a Unix-like system):

Description of the problem including expected versus actual behavior:

Steps to reproduce:

Please include a minimal but complete recreation of the problem, including
(e.g.) index creation, mappings, settings, query etc. The easier you make for
us to reproduce it, the more likely that somebody will take the time to look at it.

Provide logs (if relevant):

@romseygeek romseygeek added >enhancement :Search/Search Search-related issues that do not fall into other categories labels Apr 3, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jimczi
Copy link
Contributor

jimczi commented Apr 3, 2018

Some options that were available on the multi_match and match queries are no longer available in the match_phrase query. You could use a multi_match query and set the type to phrase but I agree that it would be nice to re-enable the support for zero_terms_query option in a simple match_phrase query. Would you like to work on a pull request for this issue @JFogh ? Otherwise I'll mark the issue with an adoptme tag.

@JFogh
Copy link
Author

JFogh commented Apr 9, 2018

@jimczi I do not think I will have time to look into it, in the near future - so maybe the "adoptme"-tag would be fine.

@jimczi jimczi added the help wanted adoptme label Apr 9, 2018
@jimczi
Copy link
Contributor

jimczi commented Apr 9, 2018

Ok thanks @JFogh

@jtibshirani
Copy link
Contributor

jtibshirani commented Apr 19, 2018

This functionality was added in #29598.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories v6.3.0 v7.0.0-beta1
Projects
None yet
Development

No branches or pull requests

6 participants