-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Ion Serialization Format #25272
Comments
I suspect that we are unlikely to accept this as it means:
I will leave this open for others to opine. |
Thanks. I can certainly understand and appreciate wanting to minimize the dependency footprint. My follow up question would be whether you are open to making this customizable via plugins? (providing your own XContentType) |
Since I would love to move some of those content types out to modules/plugins, I think making the content type impls pluggable would be great. I do expect it would take a bit of work, and I don't think it is a priority right now. @scottsom Are you interested in working on this? It would most likely involve a few PRs to clean some things up, in addition to the actual pluggable part. I would be happy to work through this with you. |
Discussed in FixItFriday - would be good to make our existing formats into modules. |
@rjernst Don't think I can work on this one right now but I may re-visit this in the future. Thanks. |
This has sat open for most of a year without a comment. We've got a ton to do so I don't think we'll be working on making x-content types pluggable any time soon. I think if someone gets interested in this in the future we can reopen it and discuss again, but for now I think the right thing to do is close this as "won't fix any time soon". |
Since Elasticsearch already accepts JSON, YAML, Smile, and CBOR then I'd like to submit Amazon Ion for consideration. To implement a new XContentType, we just need the Jackson bindings which are available from jackson-dataformat-ion.
However, I see that you guys are already on the fence about supporting 4 different types as discussed in #22811.
I can work on a patch and some benchmarks but before I get too invested, I wanted to check on the likelihood of it being accepted considering the previous discussion.
The text was updated successfully, but these errors were encountered: