Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back documentation on disable _source #12141

Closed
ppf2 opened this issue Jul 9, 2015 · 1 comment
Closed

Add back documentation on disable _source #12141

ppf2 opened this issue Jul 9, 2015 · 1 comment
Labels
>docs General docs changes

Comments

@ppf2
Copy link
Member

ppf2 commented Jul 9, 2015

Currently, our 1.x doc (https://www.elastic.co/guide/en/elasticsearch/reference/1.x/mapping-source-field.html#mapping-source-field) includes information on:

  • Ability to disable _source
  • includes/excludes functionality for _source being deprecated in 1.6.0

In #10915, we removed the ability to disable _source, and then it was subsequently added back in #11171. But it appears that when we added this back, we haven't gone back and updated the documentation to re-add the information on disabling _source and the includes/excludes usage. So the latest doc in master is missing this information:

https://www.elastic.co/guide/en/elasticsearch/reference/master/mapping-source-field.html#include-exclude (doc in master)

https://github.com/elastic/elasticsearch/commits/d32a80f37b1e09d37b1556ba5cce74d0b76bb8c4/docs/reference/mapping/fields/source-field.asciidoc (history of doc changes)

This is a request to add back the documentation on disabling source and the caveats mentioned here (#11116 (comment)) now that the feature has returned. And since the feature is back, I think it also means that includes/excludes is no longer "deprecated"?

@ppf2 ppf2 added the >docs General docs changes label Jul 9, 2015
@ppf2
Copy link
Member Author

ppf2 commented Jul 10, 2015

thx! @clintongormley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes
Projects
None yet
Development

No branches or pull requests

1 participant