Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold plugin script into elasticsearch script with -plugin option #11797

Closed
kimchy opened this issue Jun 22, 2015 · 7 comments
Closed

Fold plugin script into elasticsearch script with -plugin option #11797

kimchy opened this issue Jun 22, 2015 · 7 comments
Labels
>breaking :Core/Infra/Plugins Plugin API and infrastructure good first issue low hanging fruit help wanted adoptme

Comments

@kimchy
Copy link
Member

kimchy commented Jun 22, 2015

Today, we highjack a generic script name called plugin to install plugins with ES. Other products might have this script name and it would be nice if we are better citizens of $PATH here. We should allow to install plugins using the elasticsearch script, and deprecate the plugin script.

@jimmyjones2
Copy link
Contributor

Same as #11651?

@proegssilb
Copy link

Fixes the same problem as #11651, but different proposal. This approach would still make packaging on Linux a lot easier, unless a distro decides to replace the elasticsearch script (I don't work on distros, I don't know how likely it is).

@clintongormley
Copy link
Contributor

We've decided against doing this as bin/elasticsearch should be run as the elasticsearch user, and bin/plugin as root

@jimmyjones2
Copy link
Contributor

This is fine, but a bit unfortunate that downstream packagers will always have to use a different name to upstream. How about elasticsearch-plugin?

@Hubbitus
Copy link

In Fedora we already use name elasticsearch-plugin. But in any case as it should be compiled from source without network build procedure and start script significant differs than shipped upstream. Meantime it will be helpful if such distinguished name will appear in docs.

@clintongormley
Copy link
Contributor

@Hubbitus this is happening in #16022

@Hubbitus
Copy link

@clintongormley thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Core/Infra/Plugins Plugin API and infrastructure good first issue low hanging fruit help wanted adoptme
Projects
None yet
Development

No branches or pull requests

5 participants