Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify RoleDescriptor from get_service_account and create_api_key #1727

Closed
swallez opened this issue May 24, 2022 · 0 comments · Fixed by #1787
Closed

Unify RoleDescriptor from get_service_account and create_api_key #1727

swallez opened this issue May 24, 2022 · 0 comments · Fixed by #1787

Comments

@swallez
Copy link
Member

swallez commented May 24, 2022

In #1723 we updated security.create_api_key.RoleDescriptor so that it matches security.get_service_account.RoleDescriptor. These types are actually a single type and should be merged.

This is a breaking change since this means renaming that single type to security._types.RoleDescriptor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant