Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosshair line for Line / Area charts is too light #925

Closed
elizabetdev opened this issue Nov 30, 2020 · 2 comments · Fixed by #980
Closed

Crosshair line for Line / Area charts is too light #925

elizabetdev opened this issue Nov 30, 2020 · 2 comments · Fixed by #980
Assignees
Labels
bug Something isn't working released Issue released publicly

Comments

@elizabetdev
Copy link
Contributor

Describe the bug

The crosshair line for Line/Area charts is too light. There is an open discussion in EUI (elastic/eui#4308).

To Reproduce

  1. Go to https://elastic.github.io/elastic-charts/?path=/story/line-chart--basic
  2. Move the mouse over the line chart
  3. The crosshair line is too light

Expected behaviour

The expected behaviour is that the line charts get the crosshair.line styles and right now it is getting the crosshair.band styles which are too light in color:

https://github.com/elastic/eui/blob/c0b8a25095e9fd60a5a9911d0cb1ba1249400ebf/src/themes/charts/themes.ts#L172-L181

Screenshots

Screenshot 2020-11-25 at 12 49 11

Kibana Cross Issues

This issue was noticed while working on:
elastic/kibana#81565

@markov00
Copy link
Member

@miukimiu you are right, the vertical line use the crosshair.band for its background color because the line theme is used for the horizontal line and should receive a different style (visible when using the tooltip type crosshair as shown here: https://elastic.github.io/elastic-charts/?path=/story/interactions--crosshair-with-time-axis)

I will update the API to support the following:

  • line/band as described today but line is used for the vertical line instead of the horizontal one
  • crossLine: the style for the horizontal line

@markov00
Copy link
Member

🎉 This issue has been resolved in version 24.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants