Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chart type to chart label #1098

Closed
myasonik opened this issue Mar 30, 2021 · 1 comment
Closed

Add chart type to chart label #1098

myasonik opened this issue Mar 30, 2021 · 1 comment
Labels
:accessibility Accessibility related issue bug Something isn't working

Comments

@myasonik
Copy link

Describe the bug

Each chart has a simple aria-label="Chart". Next step is to add the chart type to it.

Expected behavior

Examples include aria-label="Bar chart", aria-label="Bubble chart", etc

Implementation notes

  • If passing in labeling props is supported when this is implemented, the user supplied label should overwrite this
@myasonik myasonik added bug Something isn't working :accessibility Accessibility related issue labels Mar 30, 2021
@myasonik myasonik mentioned this issue Mar 30, 2021
Closed
@myasonik myasonik mentioned this issue Apr 6, 2021
Merged
1 task
@rshen91
Copy link
Contributor

rshen91 commented Apr 14, 2021

Closed by #1104

@rshen91 rshen91 closed this as completed Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:accessibility Accessibility related issue bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@myasonik @rshen91