-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker image running Elastic Agent in Otel mode #5246
Comments
Ideally we should keep all components in the image for now and minimize the differences between this and the existing image until we have a better idea of how long this will be around for and what the use-cases will be.
I wish I knew more about the build process but I would have thought that we could have just built from the existing image:
And saved ourselves from adding a whole new image pipeline? Or just put the otel CMD part in a conditional and otherwise have the two images be identical? |
It might actually be simpler if we just implement this as an environment variable like Thinking more, one day we probably want to obsolete the elastic-agent-otel container because it will be the same as elastic-agent so we can just save ourselves the trouble. |
@michalpristas Is this change already included in The following command seems not to be launching the otel binary yet (or ELASTIC_AGENT_OTEL="true"):
|
@rogercoll This is not in |
I can confirm that |
If someone needs to make it work with version 8.15.x, please note that we need to overwrite the command and also the entrypoint. Sharing a sample services:
elastic-agent:
image: docker.elastic.co/beats/elastic-agent:8.15.1
container_name: elastic-agent # instead of
restart: no
entrypoint: "elastic-agent"
command: ["otel", "-c", "/etc/elastic-agent/otel.yaml"]
volumes:
- type: bind
source: ./otel.yaml
target: /etc/elastic-agent/otel.yaml |
Currently agent start in normal mode by default.
Only way how to change that is overriding command that's executed.
This approach is not always viable.
For this reason we should create and additional image where agent starts in otel mode.
@cmacknz while we're at it it would be nice to consider making this image slim and get rid of all the agent boilerplate that is not needed when running otel (as this will be explicitly named
elastic-agent-otel
).What i have in mind is symlink to binary and all beats/endpoint...
The text was updated successfully, but these errors were encountered: