Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Create a new Custom log integration's that relies on filestream #3881

Closed
nimarezainia opened this issue Dec 7, 2023 · 14 comments
Labels
Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Integrations Label for the Integrations team

Comments

@nimarezainia
Copy link
Contributor

nimarezainia commented Dec 7, 2023

log input is being deprecated and superseded by filestream. Custom log integration is still using log input and we would need a new integration relying on filestream.

Acceptance Criteria:

  • The already existing Custom log integration should be renamed to something like - Custom log (legacy)
  • A new Custom log integration should be created based on a filestream
@pierrehilbert
Copy link
Contributor

Hey Nima,
Could you please fill a bit more the issue with the Definition of Done?

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Dec 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@nimarezainia
Copy link
Contributor Author

@cmacknz are you happy with the estimate on this?

@cmacknz
Copy link
Member

cmacknz commented Feb 12, 2024

I think so, but it may change once someone takes a closer look at the changes that are needed.

The complexity here comes from the fact that if we change the input type every existing custom logs input will re-ingest previously ingested data. I think the filestream take over mode can address this but I don't think we've tried it with an integration yet. We'll need someone to investigate the best approach here.

@mbudge
Copy link
Contributor

mbudge commented Apr 16, 2024

We need these filestream settings to be accessible in Fleet UI

scan_frequency
ignore_older
close_inactive
harvester_limit
prospector.scanner.include_files

parsers:
- multiline:
type: pattern
max_lines: 1000
pattern: '^======'
negate: true
match: after
flush_pattern: '======

@ycombinator ycombinator added Team:Integrations Label for the Integrations team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Apr 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@nimarezainia
Copy link
Contributor Author

To minimize disruption to existing deployments we should have a legacy log input as the default and an option for the user to enable a filestream input as well.

Image

@strawgate
Copy link
Contributor

@nimarezainia will review with @jlind23 tomorrow and report back if we can proceed with this plan!

@mbudge
Copy link
Contributor

mbudge commented Jul 16, 2024

Any update?

@andrewkroh
Copy link
Member

@strawgate
Copy link
Contributor

We're looking into making a Filestream integration available and marking the existing custom log integration as legacy (but still available). We will keep this issue open to track interest in a more seamless migration capability.

@jlind23 jlind23 changed the title [Elastic Agent] Migrate Custom log integration's log input to using filestream [Elastic Agent] Create a new Custom log integration's that relies on filestream Aug 29, 2024
@jlind23
Copy link
Contributor

jlind23 commented Aug 29, 2024

@strawgate @nimarezainia @pierrehilbert updated this issue description and title.

@nimarezainia
Copy link
Contributor Author

I created #5370 a few days ago. We believe that adding a new filestream custom integration is the better approach.

cc: @flexitrev

@jlind23
Copy link
Contributor

jlind23 commented Aug 30, 2024

Thanks @nimarezainia i'll close this one as duplicate.

@jlind23 jlind23 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

9 participants