Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish full support of "reusable" field sets #328

Closed
webmat opened this issue Feb 15, 2019 · 1 comment
Closed

Finish full support of "reusable" field sets #328

webmat opened this issue Feb 15, 2019 · 1 comment

Comments

@webmat
Copy link
Contributor

webmat commented Feb 15, 2019

#155 describes what's actually a more widespread problem. Currently, schema.csv and template.json don't include any mention of the reusable field sets in their expected locations. Example: source has no mention of geo, which can be nested at source.geo.

We need to update the generator to do so. The discussion on whether we can accomplish that with path matching for ES specifically is another matter, tracked in #155.

The goal here is to have each generated file be correct and list every field, including reusable ones.

@webmat
Copy link
Contributor Author

webmat commented Feb 26, 2019

Solved by #336

@webmat webmat closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant