Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connectors using AIOHTTP module should display error messages in case of Bad Request #1906

Closed
praveen-kukreja opened this issue Nov 16, 2023 · 0 comments
Closed

Connectors using AIOHTTP module should display error messages in case of Bad Request #1906

praveen-kukreja opened this issue Nov 16, 2023 · 0 comments
Labels
enhancement New feature or request priority:low

Comments

@praveen-kukreja
Copy link
Contributor

Problem Description

Currently aiohttp has an unresolved bug due to which if any request throws 400 status code, the error message is not visible, the module itself passes self.status == 400 and self.reason == "BAD REQUEST", issue link for more details: aio-libs/aiohttp#4600.
This makes it difficult to debug a failed request from a user's perspective since the connector would only output Exception: Bad Request.

Proposed Solution

Use the solution provided here aio-libs/aiohttp#4600 (comment) in our utils. (Tested it, working fine)

Alternatives

Wait till the official version is released supporting it (aio-libs/aiohttp#3892 had been merged more than a year ago in master branch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@praveen-kukreja