Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator updates services on each reconciliation #5657

Closed
pebrc opened this issue May 11, 2022 · 0 comments · Fixed by #5663
Closed

Operator updates services on each reconciliation #5657

pebrc opened this issue May 11, 2022 · 0 comments · Fixed by #5663
Assignees
Labels
>enhancement Enhancement of existing functionality

Comments

@pebrc
Copy link
Collaborator

pebrc commented May 11, 2022

While working on #5651 I noticed that we update the services created by the operator on every single reconciliation.
Screenshot 2022-05-10 at 16 01 22

This seems to be caused by a diff in ClusterIPs where we ignore ClusterIPs when they are not a parseable IP as it is the case for None.

I don't recall why we have this special casing of non-IPs, I suspect a validation in an older version of Kubernetes might have been at play as I don't think it is there without reason. In any case we should revisit this and see if we can avoid unnecessary updates.

This needs to be tested across k8s versions probably to avoid any breakage.

@pebrc pebrc added the >enhancement Enhancement of existing functionality label May 11, 2022
@pebrc pebrc self-assigned this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant