-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to specify Docker host on Windows using named pipes #4748
Comments
It looks to me like the Docker module is using fsouza's go-dockerclient, which is the same client used by Registrator. As Registrator works correctly, this looks to me like it is simply an issue in URI validation. Maybe all that is needed is a special case in ParseURL (beats/metricbeat/mb/parse/url.go) where if the URI starts with npipe:// it just returns the raw string? |
I've opened #4751, do you have any way to build and test that branch? Unfortunately, I don't have a Windows scenario to test this fix 😇 |
Hm; I built Registrator, it's possible I could work out how to build Metricbeat. Note that it would probably be more correct to use |
I put my comments in the PR. I don't know if my simple test is enough to get your PR merged, but it LGTM. |
Thanks for the report @godefroi, this fix should make it to next release! (6.0) |
I'm using Metricbeat 5.4.2 on Windows Server 2016. I have configured the Docker module as so:
This configuration passes
metricbeat -configtest
, but it doesn't actually work. The error message reported in Elasticsearch is this:If I use
npipe:////./pipe/docker_engine
as the host (which matches what I use for Registrator),metricbeat -configtest
complains:The text was updated successfully, but these errors were encountered: