Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD][libbeat] stress-tests make goal does not work #21617

Closed
v1v opened this issue Oct 7, 2020 · 3 comments · Fixed by #21719
Closed

[BUILD][libbeat] stress-tests make goal does not work #21617

v1v opened this issue Oct 7, 2020 · 3 comments · Fixed by #21719
Labels
libbeat Team:Services (Deprecated) Label for the former Integrations-Services team

Comments

@v1v
Copy link
Member

v1v commented Oct 7, 2020

Command

$ make STRESS_TEST_OPTIONS=-timeout=20m -race -v -parallel 1 -C libbeat stress-tests

Some build examples:

  • here and
  • master build with 2.0 pipeline
  • 7.9 build with 1.0 pipeline
  • Travis, I cannot find any existing build that triggers the stress-test :/ to compare with

image

Logs

[2020-10-07T09:55:56.175Z] + make STRESS_TEST_OPTIONS=-timeout=20m -race -v -parallel 1 -C libbeat stress-tests
[2020-10-07T09:55:56.175Z] make: Entering directory '/var/lib/jenkins/workspace/Beats_beats_PR-21614/src/github.com/elastic/beats/libbeat'
[2020-10-07T09:55:56.438Z] dirname: missing operand
[2020-10-07T09:55:56.438Z] Try 'dirname --help' for more information.
[2020-10-07T09:55:56.438Z] dirname: missing operand
[2020-10-07T09:55:56.438Z] Try 'dirname --help' for more information.
[2020-10-07T09:55:56.438Z] if [ -n '' ]; then \
[2020-10-07T09:55:56.438Z] 	go test --tags=stresstest -timeout=20m -race -v -parallel 1 ; \
[2020-10-07T09:55:56.438Z] fi
[2020-10-07T09:55:56.438Z] make: Leaving directory '/var/lib/jenkins/workspace/Beats_beats_PR-21614/src/github.com/elastic/beats/libbeat'
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 7, 2020
@v1v v1v added the libbeat label Oct 7, 2020
@ph
Copy link
Contributor

ph commented Oct 7, 2020

@urso Might known more here.

@urso
Copy link

urso commented Oct 12, 2020

We did disable these stress tests a long time ago on Travis. These test the publisher pipeline by setting up a fake input and fake output with different profiles (blocking, slow, fast, eventual event drops and other scenarios). These are run for the memory queue and spooling to disk. We have had to disable them, because of performance issues in Travis, especially with spooling making almost no progress after 10min, which does lead to the run to timeout. Actually I'm a little surprised the test is enabled in the Jenkinsfile.

The Makefile tries to find all packages that have a package with a test file that contains +build stresstest in order to only run go test -tags stresstest for these packages (do not rerun all CI). The list of packages is generated here. dirname complains because it is passed an empty line it seems.

The if + go test comes from here. The output indicates that no packages are reported and there are no tests to run.

Better would be to find packages using this shell command: find . -name '*.go' 2>/dev/null | xargs grep -l 'build.*stresstest' | xargs -n1 dirname | uniq.

It seems like we haven't run any of these for a long time. Let me create a PR and see if these tests are actually stable.

@andresrc andresrc added the Team:Services (Deprecated) Label for the former Integrations-Services team label Oct 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libbeat Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants