Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat]Diskio metricset - some windows metric values expressed in increments of 100 nanoseconds #14233

Closed
narph opened this issue Oct 25, 2019 · 1 comment · Fixed by #14271
Assignees
Labels
Metricbeat Metricbeat Team:Integrations Label for the Integrations team

Comments

@narph
Copy link
Contributor

narph commented Oct 25, 2019

For the system/diskio metricset some of the metric values for windows are expressed in increments of 100 nanoseconds instead of miliseconds as stated in the docs (https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/ntdddisk/ns-ntdddisk-_disk_performance).
Options here are to:

  • update the docs and inform users about the differences between the os's
  • convert values to milliseconds
    I tend to go for the second one, what do you think @andrewkroh ?
@narph narph self-assigned this Oct 25, 2019
@narph narph added Team:Integrations Label for the Integrations team Metricbeat Metricbeat [zube]: Investigate labels Oct 25, 2019
@andrewkroh
Copy link
Member

Normalizing to a consistent unit in Beats would be good for usability. So +1 for going to milliseconds since Linux is already reporting in that unit (I'm assuming the latter part about Linux).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants