Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public API does not work on WildFly #362

Closed
felixbarny opened this issue Nov 29, 2018 · 1 comment · Fixed by #376
Closed

Public API does not work on WildFly #362

felixbarny opened this issue Nov 29, 2018 · 1 comment · Fixed by #376
Assignees
Labels
bug Bugs

Comments

@felixbarny
Copy link
Member

felixbarny commented Nov 29, 2018

See https://discuss.elastic.co/t/java-apm-agent-throws-classnotfoundexception-in-wildfly/158779

Reproduced in #361

@eyalkoren
Copy link
Contributor

Considering all factors, such as

  • implications on users
  • safety
  • robustness
  • maintainability

I chose to go with the big refactor (@felixbarny second suggested option), so that all agent code is rooted in the co.elastic.apm.agent package. OpenTracing and public APIs are not under this root.
The org.osgi.framework.bootdelegation setting was updated to allow delegation only for agent-specific classes. In addition, the actual fix for WildFly was through same enablement using s
the jboss.modules.system.pkgs setting.

I moved the changes from #361 that reproduce the problem to the refactor+fix PR (#376) because this breaks the build, so closing #361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants