Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When multiple links are included in a Slack message, only one link appears on IRC (the message is cut) #160

Closed
japsu opened this issue Sep 25, 2016 · 7 comments

Comments

@japsu
Copy link

japsu commented Sep 25, 2016

Using latest HEAD from today. Been riddled with this problem for a long time, though.

Steps to reproduce: Say tracon.fi desucon.fi on a connected channel in Slack

Expected results: <yournick> tracon.fi desucon.fi is reproduced in IRC

Actual results: <yournick> desucon.fi in IRC

Also happens with e-mail addresses.

@ekmartin
Copy link
Owner

Woops! Thanks. Should be fixed in version 3.8.3.

@japsu
Copy link
Author

japsu commented Sep 26, 2016

Thanks @ekmartin for the super-fast reply.

Unfortunately, running version 3.8.3, I'm still experiencing the same problem.

This works: https://desucon.fi https://tracon.fi
This doesn't: desucon.fi tracon.fi

If it makes any difference, I'm trying this on a private channel (no #).

Environment:

Running this docker image https://hub.docker.com/r/tracon/slackirc/
built from this Dockerfile https://github.com/tracon/ansible-tracon/blob/master/roles/slackirc/Dockerfile

@ekmartin
Copy link
Owner

Sorry, had to make the readable representation regex non-greedy as well: 1ffd30f

Please give version 3.8.4 a go and see if it fixes it. Thanks for the thorough report!

@japsu
Copy link
Author

japsu commented Sep 26, 2016

Thanks, working now!

@japsu
Copy link
Author

japsu commented Sep 26, 2016

@ekmartin I assume this is related:

Say in Slack: java.util.List<java.lang.String>

Appears in IRC: java.util.Listjava.lang.String

@ekmartin
Copy link
Owner

😞 - I'll take a look at it later :)

@japsu
Copy link
Author

japsu commented Sep 26, 2016

@jlaunonen just submitted a PR that probably fixes that :)

#161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants