Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TERCC missing pattern for links.target #271

Closed
magnusbaeck opened this issue Sep 17, 2021 · 1 comment · Fixed by #275
Closed

TERCC missing pattern for links.target #271

magnusbaeck opened this issue Sep 17, 2021 · 1 comment · Fixed by #275
Assignees
Labels
bug protocol All protocol changes
Milestone

Comments

@magnusbaeck
Copy link
Member

Description

Apparently the links.target member of TERCC doesn't have an associated pattern that checks that it looks like a UUID. I've verified that it's only TERCC that has this bug.

I suppose this warrants a patch bump of the event?

Motivation

There's clearly no reason for TERCC events to be linking to non-UUIDs. This change was introduced in 2.0.0 if the event (#155) but nothing was mentioned in the commit message.

Exemplification

N/A

Benefits

Obvious.

Possible Drawbacks

None.

@magnusbaeck magnusbaeck added this to the Edition Lyon milestone Sep 17, 2021
@magnusbaeck magnusbaeck self-assigned this Sep 17, 2021
@t-persson
Copy link
Contributor

Nice catch! Yes a Patch bump seems correct since noone should link with anything but uuid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug protocol All protocol changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants