Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modelling of COVID-19 vaccines will change #43

Open
lubianat opened this issue Mar 15, 2021 · 4 comments
Open

Modelling of COVID-19 vaccines will change #43

lubianat opened this issue Mar 15, 2021 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@lubianat
Copy link
Contributor

Hello,

I raised a point in a recent discussion post about the modelling of vaccines on Wikidata: https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_COVID-19#Ontological_organization_of_vaccines

In short, I'm planning to model the different types of vaccines as types of vaccine, and not "vaccines" themselves.
I think this might break the vaccines section. A small change (P31 to P279) in the SPARQL query would provide support.

I'd happily open a pull request with the updated query. Should I?

@egonw
Copy link
Owner

egonw commented Mar 16, 2021

Yes, please go ahead!

@egonw egonw added bug Something isn't working enhancement New feature or request labels Mar 16, 2021
@lubianat
Copy link
Contributor Author

I've tried opening a PR, is that format correct?

@egonw
Copy link
Owner

egonw commented Mar 16, 2021

Yes, but wrong folder. Everything in docs/ is generated. Look up the query in src/sparql/ please. Sorry for the confusion.

@lubianat
Copy link
Contributor Author

Oh no, I did it again, sorry. I'm gonna fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants