Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egg-bin中istanbul覆盖率支持json-summary #1071

Closed
johnnychq opened this issue Jun 19, 2017 · 7 comments · Fixed by eggjs/bin#64
Closed

egg-bin中istanbul覆盖率支持json-summary #1071

johnnychq opened this issue Jun 19, 2017 · 7 comments · Fixed by eggjs/bin#64

Comments

@johnnychq
Copy link
Contributor

johnnychq commented Jun 19, 2017

RT, egg-bin中 cov命令里关于istanbul的format格式写死了,无法配置

egg-bin中的源码位置:

/**
   * get coverage report args
   * @param {String} coverageDir - coverage result directory
   * @return {Array} args for istanbul coverage report
   * @protected
   */
  getReportArgs(coverageDir) {
    return [
      'report',
      '--root', coverageDir,
      'text-summary',
      'json',
      'lcov',
    ];
  }

是否可以提供配置化,目前我们需要json-summary格式,用于云效或aone等流程构建平台能够抓取总的覆盖率报告结果。

@atian25
Copy link
Member

atian25 commented Jun 19, 2017

可以考虑提供个 --cov-reporter=json-summary 的参数,欢迎 PR。

@popomore eggjs/bin#63 里面也考虑下这个?

@popomore
Copy link
Member

默认加上吧,不用加参数

@atian25
Copy link
Member

atian25 commented Jun 19, 2017

@popomore 换掉 text-summary?

@popomore
Copy link
Member

Text 有用的,命令行里要看的

@atian25
Copy link
Member

atian25 commented Jun 19, 2017

@JohnnyCheneggjs/bin#64 支持了,等 ci 过就合并发版本,今天 ci 有点慢。

@johnnychq
Copy link
Contributor Author

@atian25 赞!~

@atian25 atian25 reopened this Jun 19, 2017
@atian25
Copy link
Member

atian25 commented Jun 19, 2017

合并后会自动 close,不用手动 close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants