diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..48f9944f --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,24 @@ + + +##### Checklist + + +- [ ] `npm test` passes +- [ ] tests and/or benchmarks are included +- [ ] documentation is changed or added +- [ ] commit message follows commit guidelines + +##### Affected core subsystem(s) + + + +##### Description of change + diff --git a/index.js b/index.js index e001a103..823373bb 100644 --- a/index.js +++ b/index.js @@ -10,12 +10,6 @@ class EggBin extends Command { // load directory this.load(path.join(__dirname, 'lib/cmd')); - - /* istanbul ignore if */ - if (process.platform === 'win32') { - console.warn('`cov` is replaced with `test` at windows'); - this.alias('cov', 'test'); - } } } diff --git a/lib/cmd/cov.js b/lib/cmd/cov.js index 72612788..9894773c 100644 --- a/lib/cmd/cov.js +++ b/lib/cmd/cov.js @@ -35,6 +35,12 @@ class CovCommand extends Command { } * run(context) { + /* istanbul ignore if */ + if (process.platform === 'win32') { + console.warn('`cov` is replaced with `test` at windows'); + return yield super.run(context); + } + const { cwd, argv, execArgv } = context; const tmpDir = path.join(cwd, '.tmp'); yield mkdirp(tmpDir); diff --git a/package.json b/package.json index 4d643ffb..5e2f125e 100644 --- a/package.json +++ b/package.json @@ -10,28 +10,28 @@ "dependencies": { "change-case": "^3.0.1", "co-mocha": "^1.2.0", - "common-bin": "^2.2.0", - "debug": "^2.6.3", + "common-bin": "^2.3.0", + "debug": "^2.6.4", "detect-port": "^1.1.1", "egg-utils": "^2.1.0", "globby": "^6.1.0", "intelli-espower-loader": "^1.0.1", "istanbul": "^1.1.0-alpha.1", - "mocha": "^3.2.0", + "mocha": "^3.3.0", "mz-modules": "^1.0.0", "power-assert": "^1.4.2", - "ypkgfiles": "^1.3.1" + "ypkgfiles": "^1.4.0" }, "devDependencies": { - "autod": "^2.7.1", + "autod": "^2.8.0", "babel": "^6.3.26", "babel-preset-airbnb": "^1.0.1", "babel-register": "^6.4.3", "coffee": "^3.3.0", "cross-env": "^3.1.3", - "egg-ci": "^1.5.0", + "egg-ci": "^1.6.0", "enzyme": "^2.0.0", - "eslint": "^3.18.0", + "eslint": "^3.19.0", "eslint-config-egg": "^3.2.0", "jsdom": "^8.0.1", "mm": "^2.1.0", diff --git a/test/lib/cmd/pkgfiles.test.js b/test/lib/cmd/pkgfiles.test.js index 993e9216..72e178f0 100644 --- a/test/lib/cmd/pkgfiles.test.js +++ b/test/lib/cmd/pkgfiles.test.js @@ -33,7 +33,7 @@ describe('test/lib/cmd/pkgfiles.test.js', () => { yield fs.writeFile(path.join(cwd, 'package.json'), '{}'); yield coffee.fork(eggBin, [ 'pkgfiles', '--check' ], { cwd }) - .debug() + // .debug() .expect('stderr', /pkg.files should equal to \[ app, config, app.js ], but got \[ {2}]/) .expect('code', 1) .end();