Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title tags not respected in generated statics #6

Closed
basz opened this issue Nov 30, 2017 · 1 comment
Closed

Title tags not respected in generated statics #6

basz opened this issue Nov 30, 2017 · 1 comment

Comments

@basz
Copy link

basz commented Nov 30, 2017

Per advise of the fast boot add-on i'm using https://github.com/kimroen/ember-cli-document-title to set titles. In the running app this is respected, but not in the outputted static html...

Haven't tested the other addons to set other meta tags, but I'm guessing those aren't respected either...

@ef4
Copy link
Owner

ef4 commented Dec 15, 2017

As far as I can tell, ember-cli-document-title doesn't really work right with fastboot unless you also use ember-cli-head, and follow these instructions.

This is not caused by prember, you can verify by running your app under fastboot without prember and you'll see that titles are missing there too.

I just added some test coverage to verify that we can definitely set <title> and <meta> tags from within prember.

@ef4 ef4 closed this as completed Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants