Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on canary: {{#with}} is deprecated #45

Open
gitKrystan opened this issue Feb 2, 2021 · 2 comments
Open

Error on canary: {{#with}} is deprecated #45

gitKrystan opened this issue Feb 2, 2021 · 2 comments

Comments

@gitKrystan
Copy link

Hello there!

We are running into this deprecation on our canary builds:

Template Compiler Error (broccoli-persistent-filter:TemplateCompiler) in ember-elsewhere/templates/components/from-elsewhere.hbs

`{{#with}}` is deprecated. If you always want the block to render, replace `{{#with}}` with `{{#let}}`. If you want to conditionally render the block, use `{{#let}}` together with `{{#if}} instead. ('ember-elsewhere/templates/components/from-elsewhere.hbs' @ L6:C6) 

Looks like it comes from this template:

{{#with active.lastObject.component as |c|}}
{{component c}}
{{/with}}

Happy to make a PR if you'd like. I don't know enough about ember-elsewhere to know if I should make the block render conditionally or if just replacing {{#with}} with {{#let}} would be appropriate. Thoughts?

@chancancode
Copy link

The deprecation for "property fallback" (i.e. use this.active.lastObject.component instead of active.lastObject.component) is about to land on canary as well

@cah-brian-gantzler
Copy link
Contributor

this was fixed with #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants