Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow explicit <Chunk contentKey /> #10

Open
ericclemmons opened this issue Jul 10, 2020 · 0 comments
Open

Allow explicit <Chunk contentKey /> #10

ericclemmons opened this issue Jul 10, 2020 · 0 comments

Comments

@ericclemmons
Copy link
Contributor

Rather than computing automatically, this would allow for key-based translations to be passed in:

<Chunk contentKey="home.greeting">{t('home.greeting')}</Chunk>

I still recommend letting the content itself become the key, but this helps disambiguate when strings are the same but in different contexts (e.g. Sign Up buttons on different product plans)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant