Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise the connector for the exchange #2

Closed
perllaghu opened this issue Mar 11, 2020 · 1 comment
Closed

Generalise the connector for the exchange #2

perllaghu opened this issue Mar 11, 2020 · 1 comment

Comments

@perllaghu
Copy link
Collaborator

Currently the nbgrader plugin exchange.py code has

    base_service_url = Unicode(
        os.environ.get("NAAS_BASE_URL", "https://noteable.edina.ac.uk")
    ).tag(config=True)

    def service_url(self):
        this_url = urljoin(self.base_service_url, "/services/nbexchange/")
        self.log.debug(f"service_url: {this_url}")
        return this_url

and the exchange app.py has

        for handler in handlers.default_handlers:
            for url in handler.urls:
                self.handlers.append((url_path_join(self.base_url, url), handler))

(where base_url = os.environ.get("JUPYTERHUB_SERVICE_PREFIX", "/services/nbexchange/")

This was all built assuming the exchange was a service managed by the hub, rather than a separate thing.

This needs to be revisited.

@perllaghu
Copy link
Collaborator Author

This has been addressed.... it's the same as issues #25 & #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant