Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 64bit build fails, dll name mismatch naming convention assumed by Java code #408

Closed
aragozin opened this issue Aug 3, 2018 · 1 comment

Comments

@aragozin
Copy link

aragozin commented Aug 3, 2018

I'm trying to build 64 bit windows version from master branch.

Build generates dll named libj2v8-windows-x86_64.dll though it seems that LibraryLoader.java expects dll to be named libj2v8_win32_x86_64.dll. As a result JUnit tests are failing unable to load native library.

When I have change dll name by hand from libj2v8-windows-x86_64.dll -> libj2v8_win32_x86_64.dll and rebuild jar, tests have been passed.

@irbull
Copy link
Member

irbull commented Jan 10, 2019

We are limiting the scope of this project to V8 on Android only. I don't have the cycles to support all the different platforms. See #441 for more information. If someone would like to submit a PR for windows builds (that doesn't break the Android builds), I can apply it, but I won't be providing windows binaries.

@irbull irbull closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants