Any way to disable Require-Capability processing

[ppogorzelski]

As I understand Require-Capability is only a hint for p2 and not used in the runtime. Is there any way to disable it? I got Apache Aries JPA plugin in my build which contributes Require-Capability without version causing Tycho to crash.

[laeubi]

can you share an example of the 'crash'?

[ppogorzelski]

It's logged as WARNING, nevertheless causes build failure.

Offending MANIFEST entry:

Require-Capability: osgi.extender;osgi.extender="aries.jpa",osgi.servi
ce;effective:=active;objectClass="javax.persistence.spi.PersistencePr
ovider";javax.persistence.provider="org.eclipse.persistence.jpa.Persi
stenceProvider",osgi.extender;filter:="(&(osgi.extender=osgi.componen
t)(version>=1.4.0)(!(version>=2.0.0)))",osgi.ee;filter:="(&(osgi.ee=J
avaSE)(version=11))"

After removing non versioned capabilities the build goes through:

Require-Capability: osgi.extender;filter:="(&(osgi.extender=osgi.compo
nent)(version>=1.4.0)(!(version>=2.0.0)))",osgi.ee;filter:="(&(osgi.e
e=JavaSE)(version=11))"

Stack trace:

[WARNING] null argument:Filter is missing for required capability osgi.service in bundle com.ligertrading.nebula.common.model
org.eclipse.core.runtime.AssertionFailedException: null argument:Filter is missing for required capability osgi.service in bundle com.ligertrading.nebula.common.model
at org.eclipse.core.runtime.Assert.isNotNull (Assert.java:88)
at org.eclipse.equinox.internal.p2.metadata.RequiredPropertiesMatch.createMatchExpressionFromFilter (RequiredPropertiesMatch.java:68)
at org.eclipse.equinox.internal.p2.metadata.RequiredPropertiesMatch. (RequiredPropertiesMatch.java:50)
at org.eclipse.equinox.p2.metadata.MetadataFactory.createRequirement (MetadataFactory.java:642)
at org.eclipse.equinox.p2.publisher.eclipse.BundlesAction.addRequirement (BundlesAction.java:407)
at org.eclipse.equinox.p2.publisher.eclipse.BundlesAction.doCreateBundleIU (BundlesAction.java:235)
at org.eclipse.equinox.p2.publisher.eclipse.BundlesAction.generateBundleIUs (BundlesAction.java:1025)
at org.eclipse.equinox.p2.publisher.eclipse.BundlesAction.perform (BundlesAction.java:902)
at org.eclipse.equinox.p2.publisher.Publisher$ArtifactProcess.run (Publisher.java:288)
at org.eclipse.equinox.p2.repository.artifact.spi.AbstractArtifactRepository.executeBatch (AbstractArtifactRepository.java:222)
at org.eclipse.equinox.p2.publisher.Publisher.publish (Publisher.java:312)
at org.eclipse.tycho.p2.target.TargetPlatformBundlePublisher$PublisherRun.executePublisherAction (TargetPlatformBundlePublisher.java:224)
at org.eclipse.tycho.p2.target.TargetPlatformBundlePublisher$PublisherRun.execute (TargetPlatformBundlePublisher.java:204)
at org.eclipse.tycho.p2.target.TargetPlatformBundlePublisher.attemptToPublishBundle (TargetPlatformBundlePublisher.java:92)
at org.eclipse.tycho.p2.target.PomDependencyCollectorImpl.addMavenArtifact (PomDependencyCollectorImpl.java:64)
at org.eclipse.tycho.p2.resolver.PomDependencyProcessor.collectPomDependencies (PomDependencyProcessor.java:95)
at org.eclipse.tycho.p2.resolver.P2DependencyResolver.collectPomDependencies (P2DependencyResolver.java:317)
at org.eclipse.tycho.p2.resolver.P2DependencyResolver.computePreliminaryTargetPlatform (P2DependencyResolver.java:212)
at org.eclipse.tycho.core.resolver.DefaultTychoResolver.resolveProject (DefaultTychoResolver.java:124)
at org.eclipse.tycho.core.maven.TychoMavenLifecycleParticipant.lambda$resolveProjects$0 (TychoMavenLifecycleParticipant.java:147)
at java.util.stream.ForEachOps$ForEachOp$OfRef.accept (ForEachOps.java:183)
at java.util.stream.WhileOps$1$1.accept (WhileOps.java:99)
at java.util.ArrayList$ArrayListSpliterator.tryAdvance (ArrayList.java:1602)
at java.util.stream.ReferencePipeline.forEachWithCancel (ReferencePipeline.java:129)
at java.util.stream.AbstractPipeline.copyIntoWithCancel (AbstractPipeline.java:527)
at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:513)
at java.util.stream.AbstractPipeline.wrapAndCopyInto (AbstractPipeline.java:499)
at java.util.stream.ForEachOps$ForEachOp.evaluateSequential (ForEachOps.java:150)
at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential (ForEachOps.java:173)
at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.forEach (ReferencePipeline.java:596)
at org.eclipse.tycho.core.maven.TychoMavenLifecycleParticipant.resolveProjects (TychoMavenLifecycleParticipant.java:178)
at org.eclipse.tycho.core.maven.TychoMavenLifecycleParticipant.afterProjectsRead (TychoMavenLifecycleParticipant.java:105)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:568)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

[laeubi]

Can you share an executable minimal reproducer project?

[ppogorzelski]

Not trivial as this is a proprietary persistence bundle and non-versioned requirements are contributed there by BND (maven-bundle-plugin to be specific) based on Apache Aries JPA provided capabilities.

I'm aware the spec says versions are mandatory. It's just previous Tycho releases ignored Require-Capability headers, wondered if this behavior can be brought back by a switch.

[mickaelistria]

Require-Capability is used in OSGi Runtime, capability that match the requirements are then necessary for the bundle de be resolved and then started/activated.

[ppogorzelski]

OK, thanks Mickael. Looked at the spec once again and it says "A filter is optional". Is that a bug in Tycho?

https://docs.osgi.org/specification/osgi.core/8.0.0/framework.module.html#d0e3015

[castortech]

I've been having a quite similar issue, with capabilities and Aries as well, but a bit different.

I created a P2 site with reficio (which uses FeaturesAndBundlesPublisher ultimately).

The bundle specifies:

Provide-Capability: osgi.contract;osgi.contract=JavaJAXRS;uses:="javax .ws.rs,
 javax.ws.rs.client,javax.ws.rs.container,javax.ws.rs.core,javax.ws.rs.ext,javax.ws.rs.sse";
version:List<Version>="2.1,2,1.1"

Which means that it satisfies versions 2.1 or 2 or 1.1

Then in the content.xml we get:

<unit id='org.apache.aries.javax.jax.rs-api' version='1.0.4' singleton='false' generation='2'>
      <update id='org.apache.aries.javax.jax.rs-api' range='[0.0.0,1.0.4)' severity='0'/>
      <properties size='1'>
        <property name='org.eclipse.equinox.p2.name' value='Apache Aries JAX-RS Specification API'/>
      </properties>
      <provides size='11'>
        <provided namespace='org.eclipse.equinox.p2.iu' name='org.apache.aries.javax.jax.rs-api' version='1.0.4'/>
        <provided namespace='osgi.bundle' name='org.apache.aries.javax.jax.rs-api' version='1.0.4'/>
        <provided namespace='java.package' name='javax.ws.rs' version='2.1.0'/>
        <provided namespace='java.package' name='javax.ws.rs.client' version='2.1.0'/>
        <provided namespace='java.package' name='javax.ws.rs.container' version='2.1.0'/>
        <provided namespace='java.package' name='javax.ws.rs.core' version='2.1.0'/>
        <provided namespace='java.package' name='javax.ws.rs.ext' version='2.1.0'/>
        <provided namespace='java.package' name='javax.ws.rs.sse' version='2.1.0'/>
        <provided namespace='osgi.identity' name='org.apache.aries.javax.jax.rs-api' version='1.0.4'>
          <properties size='1'>
            <property name='type' value='osgi.bundle'/>
          </properties>
        </provided>
        <provided namespace='osgi.contract' name='JavaJAXRS' version='0.0.0'/>
        <provided namespace='org.eclipse.equinox.p2.eclipse.type' name='bundle' version='1.0.0'/>
      </provides>
     ... and more that is not relevant.

Notice the provided osgi.contract is shown as version 0.0.0 and this will fail the resolving phase in Tycho.

Also I must say that this started happening after updating the p2 site for aries. Comparing with the old one, I can see an increase in the content.xml repository version (metadataRepository version='1.2.0') and the old p2 site had no references to the osgi.contract, even if it existed just the same (that bundle manifest hasn't really changed much).

In order to get my build working, I manually edited the version to 2.1.0 and all was fine, but now I have a non-reproducible build.

So, question, is this a tycho issue, a P2 publisher issue or something else.

Thanks for your help
Alain

[laeubi]

So, question, is this a tycho issue, a P2 publisher issue or something else.

There was recently a discussion at p2 I think regarding versions @HannesWell has submited a patch, so hopefully this will be fixed soon we upgrade P2.

Beside this you can try to provide an integration-test to demonstrate the issue and we can include it to make sure it won't happen again in the future.