From d408b00b7b8b546fe23f3433d2d3aa8576d11079 Mon Sep 17 00:00:00 2001 From: Paul Latzelsperger Date: Wed, 3 May 2023 17:13:26 +0200 Subject: [PATCH] chore: remove all printstacktrace statementsw --- .../objectstore/ObjectStoreServiceInMemory.java | 4 ++-- .../service/objectstore/ObjectStoreServiceSql.java | 4 ++-- .../tractusx/edc/cp/adapter/store/SqlObjectStore.java | 8 ++++---- .../tractusx/edc/cp/adapter/store/SqlQueueStore.java | 10 +++++----- .../edc/cp/adapter/service/ResultServiceTest.java | 2 +- 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/service/objectstore/ObjectStoreServiceInMemory.java b/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/service/objectstore/ObjectStoreServiceInMemory.java index 3e1a8190a..e62581f85 100644 --- a/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/service/objectstore/ObjectStoreServiceInMemory.java +++ b/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/service/objectstore/ObjectStoreServiceInMemory.java @@ -33,7 +33,7 @@ public void put(String key, ObjectType objectType, Object object) { try { map.put(getKey(key, objectType), mapper.writeValueAsString(object)); } catch (JsonProcessingException e) { - e.printStackTrace(); + throw new IllegalArgumentException(); } } @@ -67,7 +67,7 @@ private T map(Class type, String json) { try { object = mapper.readValue(json, type); } catch (JsonProcessingException e) { - e.printStackTrace(); + throw new RuntimeException(e); } return object; } diff --git a/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/service/objectstore/ObjectStoreServiceSql.java b/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/service/objectstore/ObjectStoreServiceSql.java index b16daea50..1fb528e2c 100644 --- a/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/service/objectstore/ObjectStoreServiceSql.java +++ b/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/service/objectstore/ObjectStoreServiceSql.java @@ -70,7 +70,7 @@ private String objectToJson(Object object, String type) { try { return mapper.writeValueAsString(object); } catch (JsonProcessingException e) { - e.printStackTrace(); + throw new IllegalArgumentException(String.format("Can not parse object of type %s", type)); } } @@ -79,7 +79,7 @@ private T jsonToObject(ObjectEntity entity, Class type) { try { return mapper.readValue(entity.getObject(), type); } catch (JsonProcessingException e) { - e.printStackTrace(); + throw new IllegalArgumentException(String.format("Can not parse object of type %s", type)); } } diff --git a/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/store/SqlObjectStore.java b/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/store/SqlObjectStore.java index 4a5ec94a9..5540428f3 100644 --- a/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/store/SqlObjectStore.java +++ b/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/store/SqlObjectStore.java @@ -58,7 +58,7 @@ public void saveMessage(ObjectEntity objectEntity) { objectEntity.getType(), objectEntity.getObject()); } catch (SQLException e) { - e.printStackTrace(); + throw new EdcPersistenceException(e); } }); @@ -71,7 +71,7 @@ public ObjectEntity find(String id, String type) { var sql = statements.getFindByIdAndTypeTemplate(); return executeQuerySingle(connection, false, this::mapObjectEntity, sql, id, type); } catch (SQLException e) { - e.printStackTrace(); + throw new EdcPersistenceException(e); } }); @@ -88,7 +88,7 @@ public List find(String type) { stream.close(); return result; } catch (SQLException e) { - e.printStackTrace(); + throw new EdcPersistenceException(e); } }); @@ -101,7 +101,7 @@ public void deleteMessage(String id, String type) { var stmt = statements.getDeleteTemplate(); executeQuery(connection, stmt, id, type); } catch (SQLException | IllegalStateException e) { - e.printStackTrace(); + throw new EdcPersistenceException(e); } }); diff --git a/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/store/SqlQueueStore.java b/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/store/SqlQueueStore.java index 0d808fae1..60336eb5b 100644 --- a/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/store/SqlQueueStore.java +++ b/edc-extensions/control-plane-adapter/src/main/java/org/eclipse/tractusx/edc/cp/adapter/store/SqlQueueStore.java @@ -69,7 +69,7 @@ public void saveMessage(QueueMessage queueMessage) { toJson(queueMessage.getMessage()), queueMessage.getInvokeAfter()); } catch (SQLException e) { - e.printStackTrace(); + throw new EdcPersistenceException(e); } }); @@ -82,7 +82,7 @@ public QueueMessage findById(String id) { var sql = statements.getFindByIdTemplate(); return executeQuerySingle(connection, false, this::mapQueueMessage, sql, id); } catch (SQLException e) { - e.printStackTrace(); + throw new EdcPersistenceException(e); } }); @@ -99,7 +99,7 @@ public void deleteMessage(String id) { var stmt = statements.getDeleteTemplate(); executeQuery(connection, stmt, id); } catch (SQLException | IllegalStateException e) { - e.printStackTrace(); + throw new EdcPersistenceException(e); } } @@ -123,7 +123,7 @@ public void updateMessage(QueueMessage queueMessage) { queueMessage.getInvokeAfter(), queueMessage.getId()); } catch (SQLException | IllegalStateException e) { - e.printStackTrace(); + throw new EdcPersistenceException(e); } } @@ -146,7 +146,7 @@ public List findMessagesToSend(int max) { stream.close(); return result; } catch (SQLException e) { - e.printStackTrace(); + throw new EdcPersistenceException(e); } }); diff --git a/edc-extensions/control-plane-adapter/src/test/java/org/eclipse/tractusx/edc/cp/adapter/service/ResultServiceTest.java b/edc-extensions/control-plane-adapter/src/test/java/org/eclipse/tractusx/edc/cp/adapter/service/ResultServiceTest.java index 2b7bff25f..0c4c649de 100644 --- a/edc-extensions/control-plane-adapter/src/test/java/org/eclipse/tractusx/edc/cp/adapter/service/ResultServiceTest.java +++ b/edc-extensions/control-plane-adapter/src/test/java/org/eclipse/tractusx/edc/cp/adapter/service/ResultServiceTest.java @@ -119,7 +119,7 @@ private void sleep(long milisec) { try { Thread.sleep(milisec); } catch (InterruptedException e) { - e.printStackTrace(); + throw new RuntimeException(e); } }