From c91289bbcce414dbb5c286a352a452e257576ae4 Mon Sep 17 00:00:00 2001 From: Hoang Thuan Pham Date: Tue, 8 Mar 2022 10:25:09 -0500 Subject: [PATCH 1/2] Update windows-build-tools installation instructions windows-build-tools is now deprecated since NodeJs installer can now install all of its required tools. This commit updates the instructions on how to build Theia on Windows to inform developers about the deprecation of windows-build-tools and mark the installation instruction of the tool as fallback. Signed-off-by: Hoang Thuan Pham --- doc/Developing.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/doc/Developing.md b/doc/Developing.md index e75fa15d921f9..7097b4acca968 100644 --- a/doc/Developing.md +++ b/doc/Developing.md @@ -512,7 +512,7 @@ etc.) by opening `packages//coverage/index.html`. - Install [`nvm`](https://github.com/coreybutler/nvm-windows) with scoop: `scoop install nvm`. - Install Node.js with `nvm`: `nvm install 12.14.1`, then use it: `nvm use 12.14.1`. You can list all available Node.js versions with `nvm list available` if you want to pick another version. - Install `yarn`: `scoop install yarn`. - - Install [`windows-build-tools`](https://github.com/felixrieseberg/windows-build-tools). Run `PowerShell` as _Administrator_ and copy paste the following: `npm --add-python-to-path install --global --production windows-build-tools` + - If you need to install `windows-build-tools`, see [`Installing Windows Build Tools`](#installing-windows-build-tools). Clone, build and run Theia. Using Git Bash as administrator: @@ -524,9 +524,14 @@ git clone https://github.com/eclipse-theia/theia.git \ && yarn browser build \ && yarn browser start ``` - If you do not have Git Bash installed on your system, [get one](https://gitforwindows.org/), or use `scoop`: `scoop install git`. +### Installing Windows Build Tools + - Previously, [`windows-build-tools`](https://github.com/felixrieseberg/windows-build-tools) is required to build + Native Nodes modules on Windows. The npm package is now [`deprecated`](https://www.npmjs.com/package/windows-build-tools) because NodeJS installer can now install all the required tools that it needs, including Windows Build Tools. + - In case you need to install the tool manually, after installing `yarn`, run `PowerShell` as _Administrator_ and + copy paste the following: `npm --add-python-to-path install --global --production windows-build-tools`. + ## Troubleshooting > First make sure that you follow the steps given in the [docs](https://github.com/eclipse-theia/theia/blob/master/doc/Developing.md#run-the-browser-based-example-applicatio) correctly. From b4a837635f72ab9b2a27b48a756cc9670cc65356 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Paul=20Mar=C3=A9chal?= Date: Tue, 8 Mar 2022 14:19:21 -0500 Subject: [PATCH 2/2] formatting --- doc/Developing.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/Developing.md b/doc/Developing.md index 7097b4acca968..4ecb663c5c927 100644 --- a/doc/Developing.md +++ b/doc/Developing.md @@ -527,10 +527,9 @@ git clone https://github.com/eclipse-theia/theia.git \ If you do not have Git Bash installed on your system, [get one](https://gitforwindows.org/), or use `scoop`: `scoop install git`. ### Installing Windows Build Tools - - Previously, [`windows-build-tools`](https://github.com/felixrieseberg/windows-build-tools) is required to build - Native Nodes modules on Windows. The npm package is now [`deprecated`](https://www.npmjs.com/package/windows-build-tools) because NodeJS installer can now install all the required tools that it needs, including Windows Build Tools. - - In case you need to install the tool manually, after installing `yarn`, run `PowerShell` as _Administrator_ and - copy paste the following: `npm --add-python-to-path install --global --production windows-build-tools`. + + - Previously, [`windows-build-tools`](https://github.com/felixrieseberg/windows-build-tools) is required to build Native Nodes modules on Windows. The npm package is now [`deprecated`](https://www.npmjs.com/package/windows-build-tools) because NodeJS installer can now install all the required tools that it needs, including Windows Build Tools. + - In case you need to install the tool manually, after installing `yarn`, run `PowerShell` as _Administrator_ and copy paste the following: `npm --add-python-to-path install --global --production windows-build-tools`. ## Troubleshooting