Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing Esc not closing input box when focus is out #6773

Closed
DoroNahari opened this issue Dec 19, 2019 · 3 comments · Fixed by #12446
Closed

Pressing Esc not closing input box when focus is out #6773

DoroNahari opened this issue Dec 19, 2019 · 3 comments · Fixed by #12446
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help quick-open issues related to the quick-open vscode issues related to VSCode compatibility

Comments

@DoroNahari
Copy link
Contributor

Description

In vscode, when some input box is opened and you press esc the input box is closing(Regardless of focus).
In Theia, esc close the input box only when the focus is in the input box.

Reproduction Steps

hello-0.0.1.vsix.zip
Activate the vsix above (remove the .zip) in Theia.
Activate the command "hello world" from the command pallete -> An input box should apear.
Change the focus from the input box to something else.
Press esc the input box remain although it shouldn't.

OS and Theia version:
Local Theia 13, Theia gitpod 13

@DoroNahari DoroNahari changed the title Pressing Esc not exiting input box when focus is out Pressing Esc not closing input box when focus is out Dec 19, 2019
@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility labels Dec 19, 2019
@akosyakov
Copy link
Member

Input box do you mean modal dialogs? As far as I know the plugin system does not use Theia dialogs for some reasons, but has own implementation. We should fix it and have one implementation of dialogs.

@akosyakov akosyakov added the dialogs issues related to dialogs label Dec 19, 2019
@DoroNahari
Copy link
Contributor Author

@akosyakov akosyakov added quick-open issues related to the quick-open and removed dialogs issues related to dialogs labels Dec 19, 2019
@akosyakov
Copy link
Member

@DoroNahari ok, thanks for following up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help quick-open issues related to the quick-open vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants