Syntax highlighting not working in extension mode

[lancemao]

when using these steps to build theia IDE
https://www.theia-ide.org/doc/Composing_Applications.html
everything works fine

however, when build a hello-world extension described here:
https://www.theia-ide.org/doc/Authoring_Extensions.html
the syntax highlighting is not working, at least for Java, Javascript. Seems like JSON is working fine

OS: Mac
@theia/core version: 0.5.0

[akosyakov]

You should add @theia/textmate-grammars to your app.

[vince-fugnitto]

Closing thanks to eclipse-theia/generator-theia-extension#31

[quirinpa]

I get a node-gyp error trying to build @theia/node-pty when trying to install @theia/textmate-grammars so I can't check that this solution fixes syntax highlighting in my case. I've used https://www.theia-ide.org/doc/Composing_Applications.html and I still got no syntax highlighting (javascript). I find it strange that in the theia repository itself, examples/browser/package.json doesn't reference @theia/textmate-grammars, but if I run theia there I get syntax highlighting.

[vince-fugnitto]

I get a node-gyp error trying to build @theia/node-pty when trying to install @theia/textmate-grammars so I can't check that this solution fixes syntax highlighting in my case. I've used https://www.theia-ide.org/doc/Composing_Applications.html and I still got no syntax highlighting (javascript). I find it strange that in the theia repository itself, examples/browser/package.json doesn't reference @theia/textmate-grammars.

@quirinpa @theia/textmate-grammars has been deprecated for some time now (since v0.16.0):

[textmate-grammars] removed the @theia/textmate-grammars extension #6933

• The extension will no longer be maintained by the project and remains in the Git history for anyone who would like to reference it or maintain it.

Syntax-highlighting is now contributed by vscode plugins.

[quirinpa]

Thanks for the information @vince-fugnitto. In that case shouldn't the "vscode-builtin-javascript" give me js syntax highlighting? It is listed in my package.json theiaPlugins..

[vince-fugnitto]

Thanks for the information @vince-fugnitto. In that case shouldn't the "vscode-builtin-javascript" give me js syntax highlighting? It is listed in my package.json theiaPlugins..

Given you have plugin support (through the appropriate extensions), the vscode-builtin-javascript plugin should provide you with javascript syntax highlighting:

theia/package.json

Line 112 in 43a6b62

"vscode-builtin-javascript": "https://open-vsx.org/api/vscode/javascript/1.45.1/file/vscode.javascript-1.45.1.vsix",

[quirinpa]

Thanks. I have copied and pasted the second example package.json file in https://www.theia-ide.org/doc/Composing_Applications.html. So i got the "@theia/plugin-ext-vscode" extension.. Shouldn't this be enough?

[vince-fugnitto]

Thanks. I have copied and pasted the second example package.json file in https://www.theia-ide.org/doc/Composing_Applications.html. So i got the "@theia/plugin-ext-vscode" extension.. Shouldn't this be enough?

It should be, you can confirm you actually have the plugin present under the plugins folder (which should be downloaded by the script). When starting the application, and opening a js file you should have syntax highlighting.

[quirinpa]

It is present. But I have no syntax highlighting. Weird. Maybe I messed up somehow, but I simply followed the tutorial. Thank you very much for your quick replies. Should I open a new issue?

[vince-fugnitto]

It is present. But I have no syntax highlighting. Weird. Maybe I messed up somehow, but I simply followed the tutorial. Thank you very much for your quick replies. Should I open a new issue?

@quirinpa I was able to confirm the example works on my end:

• yarn
• yarn start

In the plugins view I see the plugins present (view > plugins):

and I have syntax highlighting present:

[quirinpa]

Theia wasn't seeing any plugins. I was doing "yarn theia start" without arguments so that's why. I'm sorry for the rookie mistake. Running "yarn start" fixes this. Thanks.