Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When localizeByDefault is used to get the translation string, the default translation characters are not loaded before i18n-preload-contribution is loaded #13330

Closed
noneghost opened this issue Jan 30, 2024 · 2 comments · Fixed by #13331
Milestone

Comments

@noneghost
Copy link
Contributor

Bug Description:

When localizeByDefault is used to get the translation string, the default translation characters are not loaded before i18n-preload-contribution is loaded。

Steps to Reproduce:

  1. use vscode-language-pack-zh-hans@1.85 plugin
  2. Translations of some of the default characters in the File menu and Edit menu did not take effect
    image
    image

Additional Information

It is possible that the default translated characters are
used too early in the package guide process, and the corresponding translation data has not yet been loaded.
image

  • Operating System:
  • Theia Version: Eclipse Theia IDE(blueprint) Version 1.45.0
  • launage plugin: vscode-language-pack-zh-hans@1.85.0 and vscode-language-pack-ja@1.85.0
@noneghost
Copy link
Contributor Author

Version 1.46.0 also has this issue

@msujew
Copy link
Member

msujew commented Jan 30, 2024

Probably introduced by #13082 in this line:

import { WebSocketConnectionProvider } from '../../browser';

I'll create a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants