Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire KeybindingContexts #12657

Closed
tsmaeder opened this issue Jun 28, 2023 · 1 comment · Fixed by #12830
Closed

Retire KeybindingContexts #12657

tsmaeder opened this issue Jun 28, 2023 · 1 comment · Fixed by #12830
Labels
keybindings issues related to keybindings

Comments

@tsmaeder
Copy link
Contributor

Feature Description:

While the context field in Keybinding is deprecated, we're still using instances of KeybindingContext internally. We should remove those contexts and rely on when expressions in the keybindings. Once that is done, we should remove the KeybindingContext API. The context field has been deprecated for three years.
The reason for this request is that the KeybindingContext interface does not offer change notification. Therefore, we cannot update the UI when the active keybindings change. The alternative would be to add change notification to KeybindingContext, but I don't think we should evolve deprecated UI. See also #12656
@tsmaeder tsmaeder added the keybindings issues related to keybindings label Jun 28, 2023
@vince-fugnitto
Copy link
Member

I believe it is a duplicate of #7849, we can close either or.

@tsmaeder tsmaeder mentioned this issue Jun 28, 2023
Closed
This was referenced Aug 11, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keybindings issues related to keybindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retire context keyword from keybindings FernandoAscencio/theia
2 participants
@tsmaeder @vince-fugnitto